Keep vm-setup from crashing when disks with identical UUID exist.

vm-setup

@@ -74,18 +74,66 @@ EOF
 }
 ###############################################################################
 
+vbox_sanitize_storage_uuid () {
+  disk_img=$1
+
+  # check if disk image exists, otherwise abort
+  if [[ ! -f "${disk_img}" ]]; then
+    echo
+    echo "${ERROR}Disk image ${BOLD}${disk_img}${NORMAL}${ERROR} does not exist on this computer. Abort. Bye!${NORMAL}"
+    exit 0
+  fi
+
+  # try to remove the same disk from media registry (just in case it exists)
+  vboxmanage closemedium disk ${disk_img} >/dev/null 2>&1
+
+  # try to get the disk UUID here...
+  vboxmanage showhdinfo "${disk_img}" >/dev/null 2>&1
+
+  if [[ $? != 0 ]]; then
+    echo
+    echo "${ERROR}Error: storage UUID already exists in virtual media registry!${NORMAL}"
+    askYesNo "${GREEN}Assign new UUID to storage (write permission needed)?${NORMAL}" true
+    if [[ $? == 0 ]]; then
+      # change the disk UUID
+      vboxmanage internalcommands sethduuid "${disk_img}"
+    else
+      echo
+      echo "${ERROR}Abort. Bye!${NORMAL}"
+      exit 0
+    fi
+  fi
+}
 
 
-###############################################################################
-# vbox_attach_medium (disk_img, port_num)
-###################
 vbox_attach_storage () {
+  ###############################################################################
+  # vbox_attach_storage (disk_img, port_num)
+  ###################
   local disk_img=$1
   local port_num=$2
-  vboxmanage storageattach "${VM_NAME}" --storagectl "${STORAGE_CONTROLLER_NAME}" ${STORAGE_EXTRA_PARAMS} --port ${port_num} --device 0 --type hdd --medium "${disk_img}"
+  vboxmanage storageattach "${VM_NAME}" --storagectl "${STORAGE_CONTROLLER_NAME}" \
+    ${STORAGE_EXTRA_PARAMS} --port ${port_num} --device 0 --type hdd --medium "${disk_img}"
 }
 
 
+###############################################################################
+# vbox_set_storage_type
+# sets storage type to "normal" to allow update (if UPDATE=1), otherwise to STORAGE_TYPE (default: "immutable")
+###################
+#
+vbox_set_storage_type () {
+  local disk_img=$1
+
+  vbox_sanitize_storage_uuid "${disk_img}"
+
+  if [[ ${UPDATE} == 1 ]]; then
+    vboxmanage modifyhd "${disk_img}" --type normal
+  else
+    vboxmanage modifyhd "${disk_img}" --type ${STORAGE_TYPE}
+  fi
+}
+
 
 # print title
 title
@@ -136,7 +184,7 @@ debug
 
 # import VM settings by id or name
 vm_settings=`get_vm_settings "${VM_ID}"`
-if [ "$vm_settings" == "" ]; then
+if [[ "$vm_settings" == "" ]]; then
     usage "${ERROR}ERROR: wrong vm_id \"${BOLD}${VM_ID}\".${NORMAL}"
 fi
 
@@ -149,7 +197,7 @@ VM_DIR="${MACHINES_DIR}/${VM_NAME}"
 
 # if registered, unregister it
 VBoxManage showvminfo "${VM_NAME}" &> /dev/null
-if [ $? -eq 0 ]; then
+if [[ $? -eq 0 ]]; then
     VBoxManage unregistervm "${VM_NAME}"
 fi
 
@@ -199,33 +247,18 @@ if [[ ${CREATE_VM} == 1 ]]; then
         --audioin on --audioout on
         # working on VB version >= 5.2.20
 
-    # set storage type to "normal" to allow update, otherwise to STORAGE_TYPE (default: "immutable")
-    if [[ ${UPDATE} == 1 ]]; then
-        if [[ "${DISK_IMAGE_1}" != "" ]]; then
-            VBoxManage modifyhd "${DISK_IMAGE_1}" --type normal
-        fi
-        if [[ "${DISK_IMAGE_2}" != "" ]]; then
-            VBoxManage modifyhd "${DISK_IMAGE_2}" --type normal
-        fi
-        if [[ "${DISK_IMAGE_3}" != "" ]]; then
-            VBoxManage modifyhd "${DISK_IMAGE_3}" --type normal
-        fi
-        if [[ "${DISK_IMAGE_4}" != "" ]]; then
-            VBoxManage modifyhd "${DISK_IMAGE_4}" --type normal
-        fi
-    else
-        if [[ "${DISK_IMAGE_1}" != "" ]]; then
-            VBoxManage modifyhd "${DISK_IMAGE_1}" --type ${STORAGE_TYPE}
-        fi
-        if [[ "${DISK_IMAGE_2}" != "" ]]; then
-            VBoxManage modifyhd "${DISK_IMAGE_2}" --type ${STORAGE_TYPE}
-        fi
-        if [[ "${DISK_IMAGE_3}" != "" ]]; then
-            VBoxManage modifyhd "${DISK_IMAGE_3}" --type ${STORAGE_TYPE}
-        fi
-        if [[ "${DISK_IMAGE_4}" != "" ]]; then
-            VBoxManage modifyhd "${DISK_IMAGE_4}" --type ${STORAGE_TYPE}
-        fi
+    # set storages' type
+    if [[ "${DISK_IMAGE_1}" != "" ]]; then
+      vbox_set_storage_type "${DISK_IMAGE_1}"
+    fi
+    if [[ "${DISK_IMAGE_2}" != "" ]]; then
+      vbox_set_storage_type "${DISK_IMAGE_2}"
+    fi
+    if [[ "${DISK_IMAGE_3}" != "" ]]; then
+      vbox_set_storage_type "${DISK_IMAGE_3}"
+    fi
+    if [[ "${DISK_IMAGE_4}" != "" ]]; then
+      vbox_set_storage_type "${DISK_IMAGE_4}"
     fi
 
     # add storage
@@ -264,7 +297,7 @@ else
     sed -i 's@\(SharedFolder.*name="'"`echo "${SF_MEDIA_NAME}"`"'".*hostPath="\)\([^"]*\)\("\)@\1'"`echo "${SF_MEDIA_TARGET}"`"'\3@g' "${VM_DIR}/${VM_NAME}.vbox"
     sed -i 's@\(MACAddress="\)\([^"]*\)\("\)@\1'"`printf '080027%02X%02X%02X' $[RANDOM%256] $[RANDOM%256] $[RANDOM%256]`"'\3@g' "${VM_DIR}/${VM_NAME}.vbox"
 
-    if [ "${DIFF_DISK_FILE}" != "" ]; then
+    if [[ "${DIFF_DISK_FILE}" != "" ]]; then
         sed -i 's@\(HardDisk.*location="\)\([^"]*diff_[^"]*\)\("\)@\1'"`echo "${USER_TMP_DIR}/${DIFF_DISK_FILE}"`"'\3@g' "${VM_DIR}/${VM_NAME}.vbox"
     fi